General examples updates by PilnyTomas · Pull Request #7727 · espressif/arduino-esp32

PilnyTomas · 2023-01-18T15:02:17Z

This PR contains improvements of more examples which have been investigated in issue #7659.

Updated examples: (to be added)

PilnyTomas · 2023-01-31T14:59:17Z

@martinius96 Could you please help me out with description on your example WiFiClientSecureEnterprise ?

me-no-dev · 2023-02-06T12:49:15Z

+
+#ifndef USE_NAME
+  #define USE_MAC
+#endif


Since you either have USE_NAME defined, or not, I suggest removing this and using #ifdef+#else in the code below. Else it looks like you could have both defined at the same time.

me-no-dev · 2023-02-06T12:51:53Z

-public:
-	Button(uint8_t reqPin) : PIN(reqPin){
-		pinMode(PIN, INPUT_PULLUP);
-		attachInterrupt(PIN, std::bind(&Button::isr,this), FALLING);


While your changes provide simpler code, the original example shows how to attach an interrupt to a class method (and that is often asked), so I suggest to keep the old way and use class instead of struct

@pedrominatel could you please explain why we went from c++ to c?

It was just a matter of getting consistency across many examples in C, and not in C++.

I would prefer to keep the FunctionalInterrupt example as is and add a new one using a simpler code, as you already did.

So we agree that the example with class Button should stay and a new one with struct Button should be added?

I agree. Is that ok for you @PilnyTomas?

@PilnyTomas this is still left to be done

me-no-dev · 2023-02-06T12:53:07Z

left some notes, otherwise LGTM

pedrominatel

I've left some minor comments (nitpicking), otherwise, LGTM.

…ion as new example

VojtechBartoska · 2023-02-15T13:27:43Z

@me-no-dev It's ready to be reviewed and merged.

* Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com>

* Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Update toolchains and openocd for ESP-IDF v4.4.4 * Update get.py to support Apple ARM64 * Update package version * Update ESP-IDF libs to v4.4.4 * Fix compilation issue caused by ESP-Insights * Update esptool to v4.4 * Update esptool to v4.5 * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (espressif#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: me-no-dev <hristo@espressif.com> Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com>

* Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com>

* Update toolchains and openocd for ESP-IDF v4.4.4 * Update get.py to support Apple ARM64 * Update package version * Update ESP-IDF libs to v4.4.4 * Fix compilation issue caused by ESP-Insights * Update esptool to v4.4 * Update esptool to v4.5 * Update package_esp32_index.template.json * Tasmota changes for core 2.0.7 * Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> * Fix change * remove duplicate fix * Delete README.md * Create README.md * Fix erratic problem when sending IPv6 UDP packet * Update WiFiGeneric.cpp --------- Co-authored-by: me-no-dev <hristo@espressif.com> Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com> Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com>

* Tasmota changes for core 2.0.7 * Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> * Fix change * remove duplicate fix * Delete README.md * Create README.md * Delete README.md * Create README.md * Tasmota * Tasmota changes for core 2.0.7 * IPv6 support * Ethernet driver JL1101 * Fix erratic problem when sending IPv6 UDP packet * Fix erratic problem when sending IPv6 UDP packet * Update package_esp32_index.template.json * Update WiFiGeneric.cpp * Update WiFiGeneric.cpp (#211) --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com>

* Update toolchains and openocd for ESP-IDF v4.4.4 * Update get.py to support Apple ARM64 * Update package version * Update ESP-IDF libs to v4.4.4 * Fix compilation issue caused by ESP-Insights * Update esptool to v4.4 * Update esptool to v4.5 * Update package_esp32_index.template.json * Tasmota changes for core 2.0.7 * Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> * Fix change * remove duplicate fix * Delete README.md * Create README.md * Fix erratic problem when sending IPv6 UDP packet * Update WiFiGeneric.cpp --------- Co-authored-by: me-no-dev <hristo@espressif.com> Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com> Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com>

* Tasmota release/ * Tasmota changes for core 2.0.7 * Tasmota changes * Tasmota 2.0.6 with IPv6 support * IPv6 support * Ethernet driver JL1101 Co-authored-by: Danii Mirsanov <daniil.mirsanov@openlm.com> * Update install-platformio-esp32.sh * Fix conflicts * Tasmota repos * overlooked `timeout` change to `timeout_ms` * Sets correct code for UART baud rate detection Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * General examples updates (espressif#7727) (#196) * Remove inline code comments for the struct description * Renamed ESPNow examples * Changed example from C++ class to C struct * Updated MultiHomedServers * Updated BT Serial examples * Added short overview of exaples - missing Enterprise * Added draft of Enterprise header note * Fixed note in README * Fixed compilation error * Changed FunctionalInterrupt example * Fixes * Returned FunctionalInterrupts to original state + added modified version as new example Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> * Fix change * remove duplicate fix * Delete README.md * Create README.md * Delete README.md * Create README.md * Tasmota * Tasmota changes for core 2.0.7 * IPv6 support * Ethernet driver JL1101 * Fix erratic problem when sending IPv6 UDP packet * Fix erratic problem when sending IPv6 UDP packet * Update package_esp32_index.template.json * Update WiFiGeneric.cpp * Update WiFiGeneric.cpp (#211) --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com> * `tv.tv_usec = (_timeout % 1000) * 1000;` align with upstream * Update package_esp32_index.template.json * allows setting buffer size after or before begin() (#242) Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com> Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> * 2.0.12 --------- Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com> Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com> Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com> Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

Remove inline code comments for the struct description

e1f49f8

PilnyTomas self-assigned this Jan 18, 2023

PilnyTomas marked this pull request as draft January 18, 2023 15:02

PilnyTomas requested a review from pedrominatel January 18, 2023 15:02

VojtechBartoska changed the title ~~Draft: Update examples based on table from #7659~~ Draft: General examples updates Jan 18, 2023

VojtechBartoska added the Type: Example Issue is related to specific example. label Jan 18, 2023

PilnyTomas and others added 4 commits January 19, 2023 13:12

Renamed ESPNow examples

714e919

Changed example from C++ class to C struct

3d8348c

Updated MultiHomedServers

1cad7c1

Merge branch 'espressif:master' into example_update

9eae97b

VojtechBartoska added the Status: In Progress ⚠️ Issue is in progress label Jan 25, 2023

PilnyTomas added 2 commits January 30, 2023 17:44

Updated BT Serial examples

fc3fe6a

Added short overview of exaples - missing Enterprise

420f290

PilnyTomas added 4 commits February 1, 2023 11:29

Added draft of Enterprise header note

372cedc

Fixed note in README

75e4d81

Fixed compilation error

4f2b58f

Changed FunctionalInterrupt example

a2dd31a

PilnyTomas marked this pull request as ready for review February 2, 2023 11:13

VojtechBartoska added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress ⚠️ Issue is in progress labels Feb 2, 2023

me-no-dev reviewed Feb 6, 2023

View reviewed changes

VojtechBartoska changed the title ~~Draft: General examples updates~~ General examples updates Feb 6, 2023

VojtechBartoska self-requested a review February 6, 2023 13:08

pedrominatel reviewed Feb 7, 2023

View reviewed changes

Fixes

ae99c71

PilnyTomas requested review from me-no-dev and pedrominatel February 7, 2023 16:30

pedrominatel approved these changes Feb 7, 2023

View reviewed changes

VojtechBartoska added this to the 2.0.7 milestone Feb 13, 2023

Returned FunctionalInterrupts to original state + added modified vers…

387e562

…ion as new example

VojtechBartoska added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Feb 15, 2023

me-no-dev merged commit 23f653a into espressif:master Feb 15, 2023

Jason2866 mentioned this pull request Apr 18, 2023

Tasmota changes tasmota/arduino-esp32#218

Merged

4 tasks

Conversation

PilnyTomas commented Jan 18, 2023 • edited by VojtechBartoska Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updated examples: (to be added)

Uh oh!

PilnyTomas commented Jan 31, 2023

Uh oh!

me-no-dev Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

me-no-dev Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

PilnyTomas Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

pedrominatel Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

me-no-dev Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

pedrominatel Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

me-no-dev Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

me-no-dev commented Feb 6, 2023

Uh oh!

pedrominatel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VojtechBartoska commented Feb 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PilnyTomas commented Jan 18, 2023 •

edited by VojtechBartoska

Loading